Misc extensions tweaks #7749
Merged
Misc extensions tweaks #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable This ensures that output variables are defined in the parent scope event if they are empty.
…adTarget Follow-up of 437e338 (`ENH: Switch extension index entry format from "s4ext" to "json"`, 2024-03-13). It removes setting of `EXTENSION_CATEGORY` and `EXTENSION_ENABLED` into the `SCRIPT_ARGS_FILE`. These variables are now extracted from the ".json" file copied into the extension build directory.
…n_test Since using "cmake -E compare_files" does not report any details, this commit explicitly report that the baseline and generated files do not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are ready to be reviewed & integrated.
List of changes:
SlicerExtensionPackageAndUploadTargetENH: Switch extension index entry format from "s4ext" to "json", 2024-03-13).EXTENSION_CATEGORYandEXTENSION_ENABLEDinto theSCRIPT_ARGS_FILE. These variables are now extracted from the ".json" file copied into the extension build directory.slicer_generate_extension_description_test: Since using "cmake -E compare_files" does not report any details, this commit explicitly report that the baseline and generated files do not match.qSlicerExtensionsManagerModelThis changes were created while working on the following pull request: