BUG: Fix warning messages when creating markups with no display nodes #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
May 15, 2024
Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManagerHelper.cxx
Show resolved
Hide resolved
Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManagerHelper.cxx
Show resolved
Hide resolved
Ex: > vtkMRMLMarkupsDisplayableManagerHelper: Failed to create widget > vtkMRMLMarkupsDisplayableManagerHelper: Failed to create interaction widget Returns without an error message when trying to create a widget if either the markups node or a display node is missing. The widget will be created once both nodes are present.
Sunderlandkyl
force-pushed
the
markups_widget_warning_fix
branch
from
1722cd5
to
f3db118
Compare
|
Thanks @lassoan, comments added. |
lassoan
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex:
Returns without an error message when trying to create a widget if either the markups node or a display node is missing. The widget will be created once both nodes are present.