Pause menu options no longer forces a song restart #14541
+54
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could be better, but could be worse too (people want this !!) if this needs a couple tweaking but otherwise good to get pulled, tell me!!!! i would've added changes that made some other restart-only settings update but it would probably break a bunch of mods + just breaking change in general even if it's like a minor thing such as timeTxt
|
here's the translated text for the warning |
|
grahhh where do i find where to put the english counterpart |
|
oh wait ... oh no, do i have to write the whole english phrase in the language file oh no |
uuuh should there be an exclamation mark here ooor
|
would have named it "pause_options_warning" but uuh i see that the pause_ prefix is used for a part in the code |
Stefan2008Git
approved these changes
Apr 30, 2024
|
@xenkap You should add this code when you press BACK on note offset menu to switch state to in-game |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could be better, but could be worse too (people want this !!)
if this needs a couple tweaking but otherwise good to get pulled, i'd be down to cooperate
i would've added changes that made some other restart-only settings update but it would probably break a bunch of mods + just breaking change in general even if it's like a minor thing such as timeTxt
(excuse my 250ms offset) demonstration video compressed from 88MB to 10MB for github's sake
https://github.com/ShadowMario/FNF-PsychEngine/assets/103583353/eb29c2c3-66f1-4243-b42e-20641986a6ab