Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove finished rating popup sprites from comboGroup #14536

Open
wants to merge 1 commit into
base: experimental
Choose a base branch
from

Conversation

xenkap
Copy link

@xenkap xenkap commented Apr 25, 2024

  • SScript conditional compilation fix for Tea/TeaCall
    are tiny prs like this okay

+ SScript compilation fix for Tea/TeaCall
Copy link
Contributor

@crowplexus crowplexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah they are

@xenkap
Copy link
Author

xenkap commented Apr 26, 2024

yippe

@xenkap
Copy link
Author

xenkap commented Apr 26, 2024

upon closer examination, seems like sometimes layering issues occur out of nowhere
will look into it when i have the time. weird, it's like the sprite is being added to the back?

@crowplexus
Copy link
Contributor

yeah that's why I didn't do it
see this check tho?

if (!ClientPrefs.data.comboStacking && comboGroup.members.length > 0) {
	for (spr in comboGroup) {
		spr.destroy();
		comboGroup.remove(spr);
	}
}

what you could do is remove the comboStacking check, and use the comboGroup.members.length > 0 to limit the amount of sprites that the group can have

var popupsLimit: Int = 32;
if (!ClientPrefs.data.comboStacking) popupsLimit = 1;

then change comboGroup.members.length > 0 to comboGroup.members.length >= popupsLimit

this solves the issue.

@crowplexus
Copy link
Contributor

crowplexus commented May 5, 2024

actually lemme go do it lol
while i think the approach works it might look weird in-game, idk, up to shadow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants