Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Editor pointer graphic fix on flixel 5.7.0+ #14495

Open
wants to merge 9 commits into
base: experimental
Choose a base branch
from

Conversation

richTrash21
Copy link

@richTrash21 richTrash21 commented Apr 18, 2024

Fixes #14703 and #14689 by creating a local pointer graphic bitmap class in Character Editor and embedding an image into it the same way as it was done in HaxeFlixel versions prior to 5.7.0 (non debug platforms only).

@richTrash21 richTrash21 changed the title Character Editor pointer graphic fix Character Editor pointer graphic fix on flixel 5.7.0+ Apr 18, 2024
Copy link

@Stefan2008Git Stefan2008Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Stefan2008Git Stefan2008Git mentioned this pull request May 2, 2024
@richTrash21 richTrash21 changed the base branch from main to experimental May 8, 2024 23:11
@SlickSquid35
Copy link

I tried replacing the CharacterEditorState.hx file with the one provided here, but I ran into the same screen without any changes, I'm still new to source code so I don't really have an idea on how to fix this.

And just to clarify, I am using the source code for FNF Psych engine 0.7.2h, so I'm not sure if this fix is meant for a newer or older version than the one I have.

Could someone help me out?

@richTrash21
Copy link
Author

richTrash21 commented May 17, 2024

And just to clarify, I am using the source code for FNF Psych engine 0.7.2h, so I'm not sure if this fix is meant for a newer or older version than the one I have.

this fix is meant for future versions of Psych engine, so directly copying whole class won't work since it got changes from upcoming version, so just copy these lines and it should work:
image
image

@mikaelrokkaa
Copy link

mikaelrokkaa commented May 21, 2024

why doesnt this work (im on the latest version of psych and flixel) im trying to fix the "black screen of death" and it wont work even after i redid this like a million times too and did everything that was shown please help
Näyttökuva 2024-05-21 151100
Näyttökuva 2024-05-27 121514

(i use visual studio 2019)
please help i wanna mod the game

@MikExpungedMoment
Copy link

i'm getting this error about ConfirmationPopupSubstate
Screenshot 2024-05-22 155136

@kpsm485
Copy link

kpsm485 commented May 28, 2024

states/editors/CharacterEditorState.hx:26: character 1 : Uncaught exception File not found 'assets/shared/images/debugger/cursorCross.png'

C:\HaxeToolkit\haxe\std/haxe/macro/Context.hx:117: characters 10-39 : Called from here

C:/Users/PC/Downloads/FNF-PsychEngine-main/FNF-PsychEngine-main/setup/openfl/9,3,3/src/openfl/utils/_internal/AssetsMacro.hx:157: characters 16-45 : Called from here

C:/Users/PC/Downloads/FNF-PsychEngine-main/FNF-PsychEngine-main/setup/openfl/9,3,3/src/openfl/utils/_internal/AssetsMacro.hx:41: characters 16-36 : Called from here

states/editors/CharacterEditorState.hx:26: character 1 : Called from here

is what im getting i have NO IDEA what to do

@richTrash21
Copy link
Author

why doesnt this work (im on the latest version of psych and flixel) im trying to fix the "black screen of death" and it wont work even after i redid this like a million times too and did everything that was shown please help Näyttökuva 2024-05-21 151100 Näyttökuva 2024-05-27 121514

(i use visual studio 2019) please help i wanna mod the game

Can you show me line 106 please? It's probably still loading graphic from GraphicCursorCross class instance which is blank on non debug targets.

@richTrash21
Copy link
Author

i'm getting this error about ConfirmationPopupSubstate Screenshot 2024-05-22 155136

Seems like you're using an older Psych version or a version that doesn't have this class. Try copying only this PR's changes, not the whole class.

@richTrash21
Copy link
Author

states/editors/CharacterEditorState.hx:26: character 1 : Uncaught exception File not found 'assets/shared/images/debugger/cursorCross.png'

C:\HaxeToolkit\haxe\std/haxe/macro/Context.hx:117: characters 10-39 : Called from here

C:/Users/PC/Downloads/FNF-PsychEngine-main/FNF-PsychEngine-main/setup/openfl/9,3,3/src/openfl/utils/_internal/AssetsMacro.hx:157: characters 16-45 : Called from here

C:/Users/PC/Downloads/FNF-PsychEngine-main/FNF-PsychEngine-main/setup/openfl/9,3,3/src/openfl/utils/_internal/AssetsMacro.hx:41: characters 16-36 : Called from here

states/editors/CharacterEditorState.hx:26: character 1 : Called from here

is what im getting i have NO IDEA what to do

'cursorCross.png' is not a locally stored graphic in this PR, so it should not mention any FNF/Psych related asset paths (like 'shared' in this case). Just use the default HaxeFlixel's pointer graphic path - 'assets/images/debugger/cursorCross.png'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants