Fix property description sublanguage

[thomas-topway-it]

fixes #5342

Implements:

Edge-Cases (only if the definition does not match)

If there is a definition in de-xxx and the wiki is in de, use the de-xxx
if there is a definition in de and the wiki is in de-xxx, use de

provides a "languagesFallbackInverse" map, with a list of dialects/formal languages for each main language.
Uses standard MW method MediaWikiServices::getInstance()->getLanguageFallback()->getFirst() for language fallback

Summary by CodeRabbit

• New Features
  • Enhanced language fallback handling for property specifications.

[coderabbitai]

Walkthrough

The SpecificationLookup class in src/Property/SpecificationLookup.php has been updated to handle language fallbacks more effectively. This includes adding necessary imports, author information, a new private property for language mappings, and a method to manage language fallbacks. These changes aim to address issues with property links not working in the "de-formal" language variant by ensuring proper fallback to the "de" language.

Changes

File Path	Change Summary
src/Property/SpecificationLookup.php	Added use MediaWiki\MediaWikiServices;, author information, a private property $languagesFallbackInverse, and a method tryOutFalldownAndInverse for language fallback handling.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure property links work in "de-formal" language (Issue #5342)	✅
Implement fallback mechanism for "de-formal" to "de" (Issue #5342)	✅

Poem

In the world of code so bright,
Languages fall back, making it right,
From "de-formal" to "de" we steer,
Property links now crystal clear.
A rabbit's touch, so swift and neat,
Ensures our code is quite the treat. 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d144a16 and 6c168ef.

Files selected for processing (1)

• src/Property/SpecificationLookup.php (6 hunks)

Additional comments not posted (5)

src/Property/SpecificationLookup.php (5)

5-5: Import statement for MediaWikiServices is necessary for the new functionality.

---

28-28: Author information update is appropriate.

---

63-377: The new private property $languagesFallbackInverse is well-defined and necessary for managing language mappings.

---

764-793: The new private method tryOutFalldownAndInverse is well-implemented and aligns with the PR objectives.

---

816-817: The update to the getTextByLanguageCode method to call tryOutFalldownAndInverse is necessary to integrate the new fallback logic.

[jaideraf]

@JeroenDeDauw this can be merged?

[JeroenDeDauw]

Design wise, the new code looks like it should be in a dedicated class.

Safety wise I see there are no automated tests. I don't trust myself or anyone else to catch all bugs just by looking at 300 lines of code.

@jaideraf did you test this PR? Does it fix the issue? Does the related functionality still work as expected?

[thomas-topway-it]

the code has been tested, however I will try to add a unit test

[thomas-topway-it]

the code has been tested, however I will try to add a test

[JeroenDeDauw]

I recommend you put the code into a dedicated service and then unit test it