Add support for evaluation of properties in slots other than 'main'

[marijnvanwezel]

See #5157.

[krabina]

any ideas why all checks are failing? @gesinn-it-gea?

[marijnvanwezel]

@krabina I think it was because tests were failing. Some because of my changes, others were already failing.

[JeroenDeDauw]

Can you rebase against master? The tests on master are working nowadays

[krabina]

@marijnvanwezel I'd really like to see this integrated. If you rebase, tests should run.

[marijnvanwezel]

I did a merge instead, as that can be done through the GitHub web interface (I am in the train, and cloning SMW takes like 30 minutes (;).

[marijnvanwezel]

Seems like there is a failing test caused by this MR:

1) SMW\Tests\MediaWiki\MwCollaboratorFactoryTest::testCanConstructEditInfo
TypeError: SMW\MediaWiki\EditInfo::__construct(): Argument #4 ($extraSemanticSlots) must be of type array, null given, called in /var/www/html/extensions/SemanticMediaWiki/src/MediaWiki/MwCollaboratorFactory.php on line 228

/var/www/html/extensions/SemanticMediaWiki/src/MediaWiki/EditInfo.php:52
/var/www/html/extensions/SemanticMediaWiki/src/MediaWiki/MwCollaboratorFactory.php:228
/var/www/html/extensions/SemanticMediaWiki/tests/phpunit/MediaWiki/MwCollaboratorFactoryTest.php:237
/var/www/html/maintenance/doMaintenance.php:107

I will see if I can fix that.

[krabina]

@marijnvanwezel any news yet?

[marijnvanwezel]

@marijnvanwezel any news yet?

Yes, the test that was previously failing is now passing. Another test fails now, but I am not sure why.

[krabina]

@JeroenDeDauw I guess we need your help here.