fix SPARQL "data" protocol (GSP) #5498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes SMW to send turtle content directly as SPARQL 1.1 GSP POST. https://www.w3.org/TR/sparql11-http-rdf-update/#http-post The problem was that internal curl_handler reused the curl options of previous call, and CURLOPT_INFILE did not set the HTTP content. There was a comment about 4store in GenericRepositoryConnector, but FourstoreRepositoryConnector overrides this part. 4store POST /data/ endpoint only supports content-type of form-urlencoded. https://github.com/4store/4store/blob/fe348295e0e20e1b2192dd08e3ef380d9750ff77/src/http/httpd.c#L1397 In SPARQL 1.1 Graph Store HTTP Protocol (GSP) spec, POST with RDF graph content is the first class, and multipart/form-data may be used as well. By the way, sending in multipart/form-data is performed by CURLOPT_POSTFIELDS with array of CURLFile instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes SMW to send turtle content directly as SPARQL 1.1 GSP POST.
https://www.w3.org/TR/sparql11-http-rdf-update/#http-post
The problem was that internal curl_handler reused the curl options of previous call, and CURLOPT_INFILE did not set the HTTP content.
There was a comment about 4store in GenericRepositoryConnector, but FourstoreRepositoryConnector overrides this part.
4store POST /data/ endpoint only supports content-type of form-urlencoded. https://github.com/4store/4store/blob/fe348295e0e20e1b2192dd08e3ef380d9750ff77/src/http/httpd.c#L1397
In SPARQL 1.1 Graph Store HTTP Protocol (GSP) spec, POST with RDF graph content is the first class, and multipart/form-data may be used as well.
By the way, sending in multipart/form-data is performed by CURLOPT_POSTFIELDS with array of CURLFile instances.