Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fixes alias being identical to name #4338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kghbln
Copy link
Member

@kghbln kghbln commented Oct 19, 2019

This PR is made in reference to: #3829

This PR addresses or contains:

  • Fixes alias being identical to name

This PR includes:

  • Tests (unit/integration)
  • CI build passed

@kghbln
Copy link
Member Author

kghbln commented Oct 19, 2019

Actually I found many more which does not make sense to me except for these are needed to map additional aliases to a name. Do not think that this is likely but ...

@kghbln kghbln changed the title Fixes alias being identical to name [DNM] Fixes alias being identical to name Jan 11, 2020
@kghbln
Copy link
Member Author

kghbln commented Jan 18, 2020

@mwjames There is probably a reason for doing this, i.e. having alias and name being identical?

@mwjames
Copy link
Contributor

mwjames commented Jan 18, 2020

@mwjames There is probably a reason for doing this, i.e. having alias and name being identical?

As far as I remember that was required by the old lang object handling (1.8x) to allow traversing the lookup. It could be that we still rely on it somewhere in the Lang.php when building the mapping between those literals. It shouldn't be necessary but I would have to confirm that which I cannot guarantee to happen anytime soon.

@kghbln
Copy link
Member Author

kghbln commented Jan 18, 2020

Thanks for the info. I just wanted to avoid unnecessary pull request rot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants