Add PluggableDataType
#3903
Add PluggableDataType
#3903
Conversation
|
https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/e88c4d94a8466ee69bd50cb4344fae6e11a91d28/docs/technical/code-snippets/register.custom.datatype.md contains details on the |
| * | ||
| * @since 3.1 | ||
| * | ||
| * @return [] |
|
|
||
| $pluggableDataType = $this->getMockBuilder( '\SMW\PluggableDataType' ) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); |
There was a problem hiding this comment.
$this->createMock( PluggableDataType::class );| * | ||
| * @return string|callable | ||
| */ | ||
| public function getClass(); |
There was a problem hiding this comment.
I'm having some problems understanding what this is about, which suggests the naming is not super.
|
Kinda painful to see new extension interfaces without scalar and return types. Maybe worth waiting till 3.2 so these can be used. Unfortunately you can't add them after the fact without creating a breaking change. |
|
@mwjames what do you think? Can we push this to 3.2? (That release can be in a few months rather than in a year if we want) |
Fine by me. |
|
Hehe, 3.2 will be released in 5 days anyway :D
|
This PR is made in reference to: #
This PR addresses or contains:
PluggableDataTypeallows for custom types to define relevant fields together with how a DV instance should be constructed.This PR includes: