Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check consistency of ParserOutput and re-parse if necessary, refs 3395 #3396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Sep 2, 2018

This PR is made in reference to: #3395

This PR addresses or contains:

  • As outlined in MW 1.32+, MCR breaks move tests #3395, this follows as regression introduced by MCR
  • We can try to cover up the issue by comparing the ParserOutput content we retrieve an see if it is consistent and in case it is not re-parse the entire content of the page (which is costly and I'd like to avoid that)
  • How do we know it fixes the issue? because all tests pass again!! [0]

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3395

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/423572872

@mwjames
Copy link
Contributor Author

mwjames commented Sep 8, 2018

Can be merged (as measure to prevent inconsistent data) BUT we keep it for now to see if any other unforeseen changes to the ParserOutput (due to MCR) will create undetected issues.

@kghbln kghbln added this to the SMW 3.1.0 milestone Oct 5, 2018
@kghbln
Copy link
Member

kghbln commented Oct 5, 2018

I have added this one to 3.1.0, however it may be brought forward to 3.0.x if there is the need to do so.

@JeroenDeDauw JeroenDeDauw removed this from the SMW 3.1.0 milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MW 1.32+, MCR breaks move tests
3 participants