Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable type hint checking #5956

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Enable mypy checks and fix issues with current type hints.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (6adac1b) to head (7f84689).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5956   +/-   ##
=======================================
  Coverage   89.75%   89.76%           
=======================================
  Files          90       90           
  Lines       22929    22939   +10     
  Branches     5020     5020           
=======================================
+ Hits        20580    20591   +11     
+ Misses       1618     1617    -1     
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review May 16, 2024 14:45
@stephenworsley stephenworsley self-requested a review May 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant