-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel concatenate #5926
base: main
Are you sure you want to change the base?
Parallel concatenate #5926
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5926 +/- ##
==========================================
- Coverage 89.78% 89.77% -0.01%
==========================================
Files 93 93
Lines 23007 23072 +65
Branches 5017 5024 +7
==========================================
+ Hits 20657 20714 +57
- Misses 1620 1624 +4
- Partials 730 734 +4 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: 11b4199Performance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to fall back on 'normal equality' when hash equality is False
?
Sorry to add more work to this, but I've been having some offline conversations with @bjlittle and @pp-mo about equality in general and we're concerned about Iris' strictness. The changes here would make Iris more strict than it is already.
We are therefore keen to use hashing as a way to confirm equality quickly and efficiently, while still retaining the chance for more lenient comparisons such as:
- Allowing
NaN
(example). - Potentially allowing for floating point differences in future (thanks to @larsbarring for insights).
If this would harm the performance gains you are looking for then we would be open to configurable behaviour in concatenate()
.
🚀 Pull Request
Description
Parallelize the comparison of the values of auxiliary coordinates, cell measures, ancillary variables, and derived coordinates during cube concatenation.
Closes #5750
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: