Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ancillary variables and cell_measures during intersect #5804

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Mar 5, 2024

🚀 Pull Request

Closes #5413.

To do:

  • Add rough functionality
  • Refactor functions into one consolidated
  • Add tests

@ESadek-MO ESadek-MO requested a review from pp-mo March 5, 2024 09:25
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (7c313ff) to head (522c247).
Report is 26 commits behind head on main.

Files Patch % Lines
lib/iris/cube.py 67.85% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5804      +/-   ##
==========================================
- Coverage   89.76%   89.74%   -0.02%     
==========================================
  Files          93       93              
  Lines       22982    23024      +42     
  Branches     5006     5021      +15     
==========================================
+ Hits        20630    20664      +34     
- Misses       1622     1628       +6     
- Partials      730      732       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO
Copy link
Contributor Author

Two notes on last commit:

  • I decided against consolidating create_coord into create_metadata as it would require so many if checks and the like it would've been harder to read. That said, I'm happy to be vetoed on this.
  • This PR threw up some flake8 errors from previous changes; cube was being used as a variable despite being imported as well. All these instances have been changed to c instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Cube loses ancillary variables and cell_measures after (some) intersections
1 participant