Lazy iris.cube.Cube.rolling_window
#5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing due to #5800. |
bouweandela
force-pushed
the
lazy-cube-rolling-window
branch
from
30092f7
to
3365ef5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5795 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 93 93
Lines 23007 23010 +3
Branches 5017 5018 +1
=======================================
+ Hits 20657 20660 +3
Misses 1620 1620
Partials 730 730 ☔ View full report in Codecov by Sentry. |
|
@trexfeathers This is now ready for review |
62 tasks
trexfeathers
requested changes
May 21, 2024
There was a problem hiding this comment.
This is looking great, thanks @bouweandela ❤
Just one thing for you to action.
trexfeathers
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Support lazy aggregation with the
iris.cube.Cube.rolling_windowmethod.Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: