Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in a vertical rule for surface fields #5734

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

馃殌 Pull Request

Closes #3820.

@ESadek-MO ESadek-MO requested a review from pp-mo February 7, 2024 09:57
@ESadek-MO ESadek-MO self-assigned this Feb 7, 2024
and level_height_coord is None
and mln_coord is None
and sigma_coord is None
):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I reckon the logic of this ought to be captured in iris.util.guess_coord_axis,
so that this test could be just if not cube.coords(axis='Z'):.

But unfortunately things like 'height' and 'depth' are not recognised by guess_coord_axis, at least at present.

@pp-mo
Copy link
Member

pp-mo commented Feb 8, 2024

Note about the currently failing tests ...

These PP save tests are checked by comparing a string representation of all the resulting PP fields against one stored in a text file under iris/tests/results/cube_to_pp.
This is done with the "cube_save_test" method supplied here.

So, you should just delete all those files, and run all tests which will re-make them.
Then commit the resulting changes, which can then be reviewed.

NOTE: for no very good reason AFAICT, this check is implemented separately from the other compare-to-stored-file tests of this nature, and does NOT require IRIS_TEST_CREATE_MISSING=1 to be set (which was probably just an oversight IMHO).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Incorrect LBLEV in pp save rules for surface fields.
2 participants