-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
466 add delay in testing and planned migration #866
base: main
Are you sure you want to change the base?
466 add delay in testing and planned migration #866
Conversation
Please remember to account for the benchmark, as testing is really computationally extensive :-D |
…Trips and Migration rules
…Trips and Migration rules
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 95.88% 95.89% +0.01%
==========================================
Files 118 118
Lines 9400 9460 +60
==========================================
+ Hits 9013 9072 +59
- Misses 387 388 +1 ☔ View full report in Codecov by Sentry. |
Basic functionality is implemented and is ready for review. However, the benchmark test is much slower than the |
Still 35% slower than the benchmark test so there's some room for optimization.Benchmark Time CPU Iterationsabm_benchmark/abm_benchmark_50k 3736 ms 3729 ms 1 Benchmark Time CPU Iterationsabm_benchmark/abm_benchmark_50k 2162 ms 2156 ms 1 |
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
LookAheadTime
).Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
closes #466