Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

466 add delay in testing and planned migration #866

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

khoanguyen-dev
Copy link
Member

@khoanguyen-dev khoanguyen-dev commented Dec 11, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • Add a time range to each type of test that determines the time it takes until the result is ready. Also add a time of validity to each test type.
  • Save the test results of each individual test of the past.
  • Add a small struct that resembles a test result.
  • Add a migration plan for each person for a certain amount of time (specified in the parameter LookAheadTime).

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

closes #466

@khoanguyen-dev khoanguyen-dev linked an issue Dec 11, 2023 that may be closed by this pull request
@xsaschako
Copy link
Member

Please remember to account for the benchmark, as testing is really computationally extensive :-D

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b0363c4) 95.88% compared to head (44f9388) 95.89%.

Files Patch % Lines
cpp/models/abm/world.cpp 89.09% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   95.88%   95.89%   +0.01%     
==========================================
  Files         118      118              
  Lines        9400     9460      +60     
==========================================
+ Hits         9013     9072      +59     
- Misses        387      388       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khoanguyen-dev
Copy link
Member Author

Basic functionality is implemented and is ready for review. However, the benchmark test is much slower than the main branch. Optimization is needed.

@khoanguyen-dev
Copy link
Member Author

Still 35% slower than the benchmark test so there's some room for optimization.

Benchmark Time CPU Iterations

abm_benchmark/abm_benchmark_50k 3736 ms 3729 ms 1
abm_benchmark/abm_benchmark_100k 7858 ms 7844 ms 1
abm_benchmark/abm_benchmark_200k 16137 ms 16119 ms 1


Benchmark Time CPU Iterations

abm_benchmark/abm_benchmark_50k 2162 ms 2156 ms 1
abm_benchmark/abm_benchmark_100k 4823 ms 4750 ms 1
abm_benchmark/abm_benchmark_200k 9604 ms 9561 ms 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delay in testing and planned migration
2 participants