Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add log for DispatchParentGestureEvents and DispatchGestureEvents #6100

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from
Open

[NUI] Add log for DispatchParentGestureEvents and DispatchGestureEvents #6100

wants to merge 1 commit into from

Conversation

JoogabYun
Copy link
Contributor

Description of Change

[NUI] Add log for DispatchParentGestureEvents and DispatchGestureEvents

API Changes

  • ACR:

@JoogabYun JoogabYun marked this pull request as ready for review April 23, 2024 08:38
hinohie
hinohie approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but do you know that NUILog.Debug print logs only if we build NUI with NUI_DEBUG_ON ? Newly added logs will not print logs for usual cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinohie hinohie hinohie approved these changes

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@everLEEst everLEEst Awaiting requested review from everLEEst everLEEst is a code owner

@rabbitfor rabbitfor Awaiting requested review from rabbitfor rabbitfor is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoogabYun @hinohie