Fixed Non-deterministic behavior of HashMap that might fail tests using ContentFragment.getExportedElements() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, Noted. Feel free to let me know after you update the PR description. Thank you! |
|
Let us know when you have updated the title, branch, and description. The changes you have made look good to me. |
SaaiVenkat
changed the title
|
@RugvedB @njain2208 I have updated the PR for your review. The necessary details are linked in the Fixed issues section. |
SaaiVenkat
changed the title
|
I went through your code and it looks good to me. I just feel that the explanation is too lengthy but if thats not an issue, then its all good. Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2608resource.getChild()when mocking theContentFragmentcauses the issue, sorting the elements loaded by the resource will solve the issue.streams().sorted()to sort the key set, and I have collected the values inListto make sure the order remains constant across different runs.