-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCL Scotch support for SWIFT #42
Open
themkots
wants to merge
69
commits into
SWIFTSIM:master
Choose a base branch
from
UCL:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ucl-scotch-build
…to ucl-scotch-build
…to ucl-scotch-build
…to ucl-scotch-build
…to ucl-scotch-build
fix: Typo value for the imbalance ratio in pick_scotch
docs: New documentation on the installation and running with SWIFT
Update README-Scotch.md
Update README-Scotch.md
fix: Formatting according to format.sh (clang-format)
fix: Clean up of excess files
fix: Formatting scripts
fix: Revert whitespace
fix: Adding defs of idx_t and IDX_MAX
* Fix for infinite loop in Brent's method * Fixed issues with missing unlocks/dependencies/debug checks for top level cells which aren't also super cells * GEAR-RT: theory * Deadlock detector * Update spin/jet AGN model * corrected number of items to write in tracers_io.h * Fix new time-step for spin-jet scheme * Grackle Cooling updates * Make the EAGLE_ICs example load the PS2020 cooling tables and not the Wiersma+09 ones * Update EAGLE_ICs README to mention how to load the Wiersma tables if needed * Add a new potential MWPotential2014 * Fix jet initial velocities * Fix EAGLE tracers' list of outputs * Add forcing terms to the hydro equations * Add barotropic EoS * Add a function so that we can mark memory as deliberately leaked at the end of the program. * Update README-Scotch.md * Update README-Scotch.md Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk> * Update README-Scotch.md Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk> * Update README-Scotch.md Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk> * Update README-Scotch.md Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk> --------- Co-authored-by: Yolan Uyttenhove <yolan.uyttenhove@ugent.be> Co-authored-by: Matthieu Schaller <schaller@strw.leidenuniv.nl> Co-authored-by: Mladen Ivkovic <mladen.ivkovic@hotmail.com> Co-authored-by: Filip Husko <filip.husko@durham.ac.uk> Co-authored-by: Yves Revaz <yves.revaz@epfl.ch> Co-authored-by: Darwin <darwin.roduit@epfl.ch> Co-authored-by: Ilektra Christidi <ilektra.christidi@ucl.ac.uk>
* fix: Passing architecture file as flag * Fixed prevailing SCOTCH invocation with configure script; made ArchData globally visible. * Fixed picking scotch when also have metis/parmetis * Fixed picking scotch when also have metis/parmetis * Fixed populating partition struct with scotch target arch file before calling initial partitioning. * Prevent destruction and empty regeneration of archdat structure. * Edited swift_fof.c to match target file updates of swift.c * Minor edits: replaced a HAVE_PARMETIS with a HAVE_METIS, edit a message to show either SCOTCH or METIS used, changed strategy flag from SCOTCH_STRATQUALITY to SCOTCH_STRATBALANCE * Added a mesage to notify when a successful SCOTCH repartition takes place * Dropping reference to METIS in pick_scotch * Changed format specifiers for SCOTCH weights reporting in debug check - now acceptable for both 32 and 64 bit versions. * Merged two separate ifdef chunks of HAVE_SCOTCH for better visibility * Dressed up naked mallocs; averaged [div by 2.0] the edge loads; removed commented out and unused code. * Updated string for averaged and not summed weights --------- Co-authored-by: Dan Giles <dangiles@Dans-MacBook-Pro.local> Co-authored-by: Themis Kotsialos <e.kotsialos@ucl.ac.uk>
* Initialised return_edge variable * Removed a typedef for idx_t and a define for SCOTCH_Idx; * Removed typedef from metis/parmetis - only code chunk.
…83647); makes scotch64 and scotch-local balance slightly better.
…33) * Update partition.c * Update configure.ac * Removal of refine in Scotch
* Update debug.c - minor edits * Update engine.c * Update swift.c * Update swift_fof.c * Update partition.c * Update partition.c
* Update README-Scotch.md * Update README-Scotch.md - Warning on compiler inclusion preferences * Update README-Scotch.md - prod runs table updates 01 * Update README-Scotch.md table runs 02 * Update README-Scotch.md remove old table * Update README-Scotch.md added note for Rome and Milan type of Cosma 8 nodes * Update README-Scotch.md * Update README-Scotch.md - prod runs table 03 * Update README-Scotch.md - large simulations dump minimisation --------- Co-authored-by: themkots <70752441+themkots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.