Make TextureGroup.ClearModified thread safe #6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacMarovitz
approved these changes
Apr 19, 2024
|
The PR solves the crashing problem with Europa (Demo) - Ryujinx/Ryujinx-Games-List#4935 I have now completed the demo and didn't come across a crash once. Thank you gdkchan! |
AcK77
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of views from the texture is passed directly on
TextureGroup.UpdateViews. That list is accessed on theClearModifiedmethod. However theClearModifiedmethod can be called from other threads (due to theMemoryUnmappedHandler). For the most part, this method seems already thread safe, except for the views list that can be modified from other threads and cause crashes. To fix this, I changed the code to store an array copy of the list, instead of a reference to the list itself.One such crashes was reported on Ryujinx/Ryujinx-Games-List#4935
Testing is welcome.