Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HID: Stub IHidServer: 134 (SetNpadAnalogStickUseCenterClamp) #6664

Merged
merged 24 commits into from May 14, 2024

Conversation

Tsubasa0504
Copy link
Contributor

@Tsubasa0504 Tsubasa0504 commented Apr 14, 2024

Allows "Power Pro" series to boot without Ignore Missing Services.

Fixes Ryujinx/Ryujinx-Games-List#4930 Ryujinx/Ryujinx-Games-List#4413
Close #1891

@github-actions github-actions bot added the horizon Related to Ryujinx.HLE label Apr 14, 2024
@ryujinx-mako ryujinx-mako bot requested review from AcK77, gdkchan, TSRBerry and a team April 14, 2024 13:22
how do i do it
Copy link
Contributor

@agatemosu agatemosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I help you format lol

src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
Tsubasa0504 and others added 2 commits April 14, 2024 22:50
Co-authored-by: Agatem <agaatem@outlook.com>
Co-authored-by: Agatem <agaatem@outlook.com>
@Tsubasa0504
Copy link
Contributor Author

thanks

@MutantAura
Copy link
Collaborator

For future reference you can run dotnet format from the command line.

@GamerzHell9137
Copy link

Fixes #1891

@GamerzHell9137
Copy link

Power Pros is launching without ignoring services

image

src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
@ryujinx-mako ryujinx-mako bot requested a review from a team April 14, 2024 21:44
@AcK77
Copy link
Member

AcK77 commented Apr 18, 2024

It seems to pass a PID too, so right now the value of the bool may be wrong.

src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
src/Ryujinx.HLE/HOS/Services/Hid/IHidServer.cs Outdated Show resolved Hide resolved
Co-authored-by: Ac_K <Acoustik666@gmail.com>
@ryujinx-mako ryujinx-mako bot requested a review from a team April 19, 2024 12:21
@Tsubasa0504
Copy link
Contributor Author

bump

@AcK77 AcK77 merged commit cada4d0 into Ryujinx:master May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
horizon Related to Ryujinx.HLE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pawapoke R - 01000c4015030000 hid IHidServer: 134 (SetNpadAnalogStickUseCenterClamp) is not implemented
7 participants