Disable keyboard controller input while swkbd is open (foreground) #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSRBerry
added
gui
This comment was marked as resolved.
This comment was marked as resolved.
TSRBerry
force-pushed
the
fix/swkbd-gui-interaction
branch
from
2226dac
to
2edd862
Compare
TSRBerry
changed the title
riperiperi
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Makes sense, though there may be a more fundamental problem here. We probably want all input to be invisible to an application while an applet is in the foreground in general. I think this will only really be an issue when we start doing LLE applets, but it's still important to consider.
gdkchan
reviewed
Apr 14, 2024
AcK77
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5625 by disabling the keyboard controller input while the swkbd applet is open.
Warning
This does not prevent keyboard controller inputs while the inline keyboard is active.
Thank you @music-discussion for figuring out the bug and describing it in the comments! It saved me quite some time and allowed me to create this PR quickly.