Replace interface/abstract types with concrete types #6621
+104
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cpu
ryujinx-mako
bot
requested review from
AcK77,
emmauss,
gdkchan,
LDj3SNuD,
riperiperi,
TSRBerry and
a team
marco-carvalho
force-pushed
the
prefer_concrete_abstract
branch
from
824f557
to
e981e0c
Compare
|
|
gdkchan
reviewed
Apr 7, 2024
| @@ -365,7 +365,7 @@ private void UpdateEffect() | |||
| _upscaledTexture = null; | |||
| break; | |||
| case ScalingFilter.Fsr: | |||
| if (_scalingFilter is not FsrScalingFilter) | |||
| if (_scalingFilter is null) | |||
| { | |||
| _scalingFilter?.Dispose(); | |||
There was a problem hiding this comment.
I think this can be removed null since it is always null?
The whole thing could be just:
_scalingFilter ??= new FsrScalingFilter(_renderer);There was a problem hiding this comment.
updated with your feedback
| @@ -559,7 +559,7 @@ private void UpdateEffect() | |||
| _isLinear = _currentScalingFilter == ScalingFilter.Bilinear; | |||
| break; | |||
| case ScalingFilter.Fsr: | |||
| if (_scalingFilter is not FsrScalingFilter) | |||
| if (_scalingFilter is null) | |||
| { | |||
| _scalingFilter?.Dispose(); | |||
There was a problem hiding this comment.
updated with your feedback
marco-carvalho
changed the title
|
@marco-carvalho Needs a rebase |
marco-carvalho
force-pushed
the
prefer_concrete_abstract
branch
from
430e8fa
to
d69544b
Compare
|
@IsaacMarovitz done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces interface/abstract types with concrete types in some sections. By specifying concrete types instead of interfaces or abstract classes, we leverage compile-time type resolution, enabling the compiler to make optimizations such as method inlining.