Add the "Auto" theme option in setting #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
reviewed
Apr 6, 2024
|
The ComboBox issue was reported upstream, and they were unable to reproduce it. amwx/FluentAvalonia#366 |
yell0wsuit
changed the title
The theme icons seemingly use Dark variant event when the OS theme is light. In addition, I added ThemeManager common to make it accessible for both App and AboutWindow
… in try block Finally solve the formatting check
|
Refactored the about dialog code. The theme icons seemingly use dark variant even when the OS theme is light. Before:
After:
|
AcK77
approved these changes
May 14, 2024
gdkchan
reviewed
May 14, 2024
| base.OnClosed(e); | ||
| if (PlatformSettings != null) | ||
| { | ||
| /// <summary> |
There was a problem hiding this comment.
I don't think XML docs does anything when unsubscribing or subscribing events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording.2024-04-06.223647.mp4
(Need to fix the font color in the dropdown when the theme changes - leave that for another issue)