feat: added ValidationApiExceptionDestructurer and unit tests. #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
On a project which I am working on, we noticed that Bearer tokens were being logged to Seq with Refit exceptions, despite the fact that we were using the
ApiExceptionDestructurer. On a closer inspection, we discovered that it was aValidationApiExceptionwhich Refit was throwing and this was not covered by theApiExceptionDestructurer.After discussing whether to change the
ApiExceptionDestructureror create a new destructurer, we settled on that, making it easy to mix and match the destructurers to suit an API's needs.To that end, I'm submitting this PR to add the
ValidationApiExceptionDestructurerto handle ValidationApiExceptions thrown by Refit.