Simpler SoftwareBitmapLuminanceSource #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
using
SoftwareBitmap.Convert
gets rid of a lot of (unsafe) code.In my testing with WinUI the new simpler implementation worked.
However, the new implementation may result in different outcomes for some inputs.
I just wanted you to know that there is a simple alternative.
So if you think that this PR is unnecessary, you can close it.
Best regards,
hig
Same PR as micjahn/ZXing.Net#466