Updated ApnsConnection createBatch #885
Open
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed one ApnsNotification failing validation in ToBytes() causing the whole batch to fail - now triggers CompleteFailed for the notifications that fail validation, skips them and continues to send the rest.
Fixed bug introduced in commit 43b4f2e where the notifications that failed validation were being added to the list of sent notifications, which causes the response processing code to attempt to CompleteSuccessfully them when another notification is returned from apple with a failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed one ApnsNotification failing validation in ToBytes() causing the whole batch to fail - now triggers CompleteFailed for the notifications that fail validation, skips them and continues to send the rest. Doesn't rely on a regex to find the failed notifications (as soon as they fail it removes them from the payload and calls the failed event). Also now tracks the state of the CompletableApnsNotification as they can fail before being sent now (during validation). Written to solve: #713