Refactored to support netstandard2.0 and net4.5 #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI Jose, This was just a port of the existing code base, so I haven't addressed any of the open issues i'm afraid, I've been using it for a while now and seems to be working fine for me so far. Ill try and have a look at them soon and merge them in if possible Mitch |
* Update PushShart using a Proxy when connecting to Google Cloud Messaging (GCM) * Options for Proxy Usage Adds properties and methods to use an HTTP-proxy in your connection, either with default network credentials or specified credentials. * Connection via proxy A method to tunnel the TCP-connection via a pre-configured HTTP-Proxy has been added. If Configuration.UseProxy is set to true, a CONNECT-request is sent using the proxy adress specified. The socket is then extracted from the stream of this request's response (using the System.Reflection-Library) and used to create a TcpClient-object. All traffic sent through this TcpClient-object will pass through the proxy used to send the initial CONNECT-Request. NOTE: The method 'getClientViaHTTPProxy' uses code that was not written by the author of this commit. The original code can be found here: https://web.archive.org/web/20160317134733/https://nitormobiledevelopment.wordpress.com/2013/08/13/push-sharp-using-proxy/ * Update ApnsConnection.cs * Update ApnsConfiguration.cs * apns wit proxy withou socket hijack * Handling proxy connection errors on APNS * Using System.Net missing in GcmConfiguration * Http Proxy with Basic authentication without WebRequest in APNS * System.Net was missing in GcmConfiguration * Using http proxy with basic auth (not using socket hijacking) in APNS * New class ProxyHelper to permit proxy connect in any place using a TcpClient * Using ProxyHelper in ApnsConnection * Supporting proxy in ApnsFeedbackService. * Changes in ApnsFeedbackService to return the tokens list intead of raising events * add proxy usage section to readme
https://gcm-http.googleapis.com/gcm/send is Error=DeprecatedEndpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Redth,
Firstly <3 the project really helps!, however it didn't support .net core (namely 2.0),
I have forked it and currently have a nuget package live (PushSharp.Core), so I can use it.
Creating this PR in case you want to pull it into your code (I did introduce breaking changes, primarily around the removal of the obsolete properties in GCM and incorrectly named class)
Effectively project now supports net45 and netstandard2.0.
if you do pull it in, ill remove more nuget package to avoid confusion,
Cheers,
Mitch