Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info about distance in Cross_correlation(export=SAC) #49

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

carmelosammarco
Copy link

I did this modification on an old version of this program and they worked very well. Now the scripts look very different and also with different function. So i hope that this time my modification works!! @ThomasLecocq if this pull request doesn't pass the check with travis-c It means that i need more time to understand the new structure but i will find a way!! :)

@ThomasLecocq
Copy link
Member

@carmelosammarco : do the test pass on your machine ? You should test locally before pushing to GitHub :)

@carmelosammarco
Copy link
Author

@ThomasLecocq OK!! :) i realised now that every time i do a commit, travis-c test it for me.. the next modifications i will try on my machine.. So every time i need to try on my machine i need to "python setup.py install" again with the new modify scripts.. after new folder and "msnoise test" right?? It is better uninstall msnoise before test again?

@ThomasLecocq
Copy link
Member

in theory yes, but you could just work in your directory and run python setup.py develop and then test elsewhere. Just note you need to delete msnoise from the site-packages/ before developping.

you can "commit" locally to keep track of what you do, but only push when the tests pass !

@ThomasLecocq
Copy link
Member

@carmelosammarco : don't worry about the failures etc... I'll try to merge your suggestions asap in master directly very soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants