Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidied error outputs #321

Merged
merged 2 commits into from
Feb 7, 2024
Merged

tidied error outputs #321

merged 2 commits into from
Feb 7, 2024

Conversation

asyates
Copy link
Contributor

@asyates asyates commented Jan 31, 2024

Stopping errors being output during processing of new codes (e.g. stack2, mwcs2, dtt2, dvv) when msnoise is functioning as intended, as makes it confusing (gives impression not working)

Largely, just stopped using params.all_components in the loops as this throws an error when files don't exist (e.g. for pairs and components combinations that were never intended to be processed). Correction in api.py, compute_dvv function a bit messy, prob cleaner way to do it.

Also was an error being output in api.py, xr_save_dvv function when only one pair for given components (with dataframe.stack().stack() then throwing an error). Now fixed.

Fixes Issue #320

@asyates
Copy link
Contributor Author

asyates commented Jan 31, 2024

Also re-added fix for previous issue #252 (same code as previous), which solves problem of df * mwcs_step being a non-integer (previous pull request with more description at #253).

@ThomasLecocq
Copy link
Member

looks good to me, ready to merge if you're happy with it ?

@asyates
Copy link
Contributor Author

asyates commented Feb 7, 2024

yes sir

@ThomasLecocq ThomasLecocq merged commit 4096d9e into ROBelgium:master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants