Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWCS: check if REF stack present #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashtonflinders
Copy link

Small change added to compute_mwcs, to check for reference file existence at each component step so it doesnt crash if the component is missing.

@ThomasLecocq ThomasLecocq changed the title Aflinders MWCS: check if REF stack present Oct 19, 2018
@ThomasLecocq
Copy link
Member

Ashton,

Thanks for the PR.

About the code itself, I don't really like the "continue" as is, this REF missing case. At least add some logging.debug("") statement or something similar.

Also, please put your name in the list in the alphabetical order.

@ashtonflinders
Copy link
Author

ashtonflinders commented Oct 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants