Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_results throws exception when dir doesn't exist #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heavelock
Copy link

I create a separate pull request to extract this feature from PR#101.

This just checks if directory created out from provided station names exists. In case it doesn't, an exception is being thrown.

There is also added a test for that exception throwing.

This change affects get_results method in API.
It also adds test method for checking that throwing
@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #107 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   73.44%   73.43%   -0.01%     
==========================================
  Files          17       17              
  Lines        2478     2481       +3     
==========================================
+ Hits         1820     1822       +2     
- Misses        658      659       +1
Impacted Files Coverage Δ
msnoise/api.py 61.07% <75%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad6c9c...e9e83a0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant