New plot type: ccf_freq #104
Conversation
- Reduces length of some lines - Uses only one text delimiter - Adds some spaces around commas
Additionally some sormatting of msnoise.py script
- Removes old docs - Renames fft method - Changes to inputs - Adds additional TODOS
Adds first two full test cases, two tests at least are pending Creates a test suite to test multiple classes.
This is just and additional feature that was introduced by other branch. I didn't want to merge it thus I just added those few lines
|
Hehe, really cool :) I actually coded that one live during the Cargèse Workshop and never finalized it ! |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 74.28% 73.42% -0.86%
==========================================
Files 17 17
Lines 2477 2480 +3
==========================================
- Hits 1840 1821 -19
- Misses 637 659 +22
Continue to review full report at Codecov.
|
|
Cool! That's good that this plot can be useful for somebody else than me :) I've updated docs and added an example image, for me it looks like almost complete. What do you think? |
|
Could you try to do only one thing per PR ? I mean, not refactoring PEP8 , adding starttime/endtime and adding a new feature at once ? It's tricky to understand as a "single PR". to remain consistent with the |
|
Sure, I will try to be more concentrated in future PRs :) If you prefer not to include the starttime/endtime args I can remove them. Yup, I will rename it. |
|
will be closed once #140 pass |
I needed a new plot type, similar to ccftime but in frequency domain. Check this out.
