Refactoring ccftime plot to use objects #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizes imports PEP8 Changes to the order of execution
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 74.28% 74.34% +0.06%
==========================================
Files 17 17
Lines 2477 2491 +14
==========================================
+ Hits 1840 1852 +12
- Misses 637 639 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For increased readibility I decided to do some refactoring of the ccftime plotting method. Instead of using general methods I've changed plot and axis to objects I'm directly referring to. I've also added a plt.close() in case the --show parameter is set to False because in my config the plot was being shown in both cases.