-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 939 return cg from parse #2563
Open
mielvds
wants to merge
6
commits into
RDFLib:main
Choose a base branch
from
mielvds:fix-939-return-cg-from-parse
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
aucampia
reviewed
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mielvds thanks for this, this is a breaking change, so I will hold off a little with merging it, as I want to release 7.0.1 or 7.1 in the next weeks, but I will merge it soon afterwards.
aucampia
added
the
backwards incompatible
will affect backwards compatibility, this includes things like breaking our interface
label
Aug 31, 2023
nicholascar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards incompatible
will affect backwards compatibility, this includes things like breaking our interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #939, which was really easy to do since most of the logic moved out of the CG parse method. Not sure whether this needed additional discussion or not; it does change the public API
Checklist
the same change.
./examples
.so maintainers can fix minor issues and keep your PR up to date.