BREAKING CHANGE: Make Literal more standards compliant #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
aucampia/20230609T2355-literal_datatype
branch
from
d051727
to
078a117
Compare
Raise an error when nested graphs occur in TriG. With this change, the <http://www.w3.org/2013/TriGTests/#trig-graph-bad-07> test passes. --------- Co-authored-by: WhiteGobo <richardfechner@posteo.net> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
Skip the following tests that rely on SPARQL 1.0 grammar and are incompatible with the SPARQL 1.1 grammar: - <http://www.w3.org/2001/sw/DataAccess/tests/data-r2/basic/manifest#term-6> - <http://www.w3.org/2001/sw/DataAccess/tests/data-r2/basic/manifest#term-7> --------- Co-authored-by: WhiteGobo <richardfechner@posteo.net> Co-authored-by: Iwan Aucamp <aucampia@gmail.com>
TBD checkpoint aucampia/20230609T2355-literal_datatype: checkpoint 20230817T000443
aucampia
force-pushed
the
aucampia/20230609T2355-literal_datatype
branch
from
078a117
to
376c034
Compare
WhiteGobo
reviewed
Sep 25, 2023
Comment on lines
+714
to
+728
| if lang is not None or datatype == _RDF_LANGSTRING: | ||
| if lang is None: | ||
| raise ValueError(f"language cannot be None if datatype is {datatype}") | ||
| if not lang: | ||
| raise ValueError("language cannot be empty string") | ||
| if not _lang_tag_regex.match(lang): | ||
| raise ValueError( | ||
| "language tag must match the pattern " | ||
| "^[a-zA-Z]+(?:-[a-zA-Z0-9]+)*$ " | ||
| f"but was {lang}" | ||
| ) | ||
|
|
||
| if datatype is None: | ||
| datatype = _RDF_LANGSTRING | ||
|
|
There was a problem hiding this comment.
Let q=Literal("ex", datatype=something). This will also overwrite any datatype given to a new Literal Literal(q, lang="en").
#prevous:
Literal(q, lang="en")
# >> Literal("ex", lang="en", datatype=something)
# now:
Literal(q, lang="en")
# >> Literal("ex", lang="en", datatype=RDF.langString)
Before the datatype was inherited. But i havent seen this behaviour documented, so there was no expected behaviour before. But we could mention this change in behaviour nonetheless.
Also this will handle issue #2603
WhiteGobo
reviewed
Sep 25, 2023
| _XSD_PFX = "http://www.w3.org/2001/XMLSchema#" | ||
| _RDF_PFX = "http://www.w3.org/1999/02/22-rdf-syntax-ns#" | ||
|
|
||
| _RDF_LANGSTRING = URIRef(_RDF_PFX + "langString") |
There was a problem hiding this comment.
It might be more useful to make _RDF_LANGSTRING a class attribute for Literal. Then someone can change the default datatype for langstring by using a childclass instead of changing it programwide.
But im not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be
None.to
rdf:langString.Related issues:
NoneandXSD.string#2123