Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdflib 4.2.2: ConjunctiveGraph.parse() return a Graph object #939

Open
flacout opened this issue Oct 14, 2019 · 0 comments · May be fixed by #2563
Open

rdflib 4.2.2: ConjunctiveGraph.parse() return a Graph object #939

flacout opened this issue Oct 14, 2019 · 0 comments · May be fixed by #2563
Labels
breaking change This involves or proposes breaking RDFLib's public API. good first issue Good for newcomers id-as-cntxt tracking related issues

Comments

@flacout
Copy link

flacout commented Oct 14, 2019

The parse function of ConjunctiveGraph modify in place the ConjunctiveGraph but return a Graph object. This is a minor issue but it can create issues down the road if the parse methode is called like so g = g.parse(source="test.ttl", format='turtle')

Demonstration:

from rdflib import Graph, ConjunctiveGraph

g = ConjunctiveGraph()
g.parse(source="test.ttl", format='turtle')
print(type(g)) # <class 'rdflib.graph.ConjunctiveGraph'>

g = ConjunctiveGraph()
g = g.parse(source="test.ttl", format='turtle')
print(type(g)) # <class 'rdflib.graph.Graph'>
JervenBolleman added a commit to JervenBolleman/rdflib that referenced this issue Dec 18, 2019
@JervenBolleman
RDFLib#939 Add a proto test. However, the behaviour is not changed to…
752050a 
… match the requestors desire
arnavpisces added a commit to arnavpisces/rdflib that referenced this issue May 29, 2020
@arnavpisces
Fixed the return type of g.parse for ConjunctiveGraph (Issue RDFLib#939)
6ea822e
arnavpisces added a commit to arnavpisces/rdflib that referenced this issue May 29, 2020
@arnavpisces
Fixed the return type of parse function of ConjunctiveGraph (Issue RD…
0e7460c 
…FLib#939)
@aucampia aucampia mentioned this issue Jun 24, 2021
Closed
aucampia pushed a commit to aucampia/rdflib that referenced this issue Jun 24, 2021
@arnavpisces @aucampia
Fixed the return type of parse function of ConjunctiveGraph (Issue RD…
1e6bd91 
…FLib#939)
aucampia pushed a commit to aucampia/rdflib that referenced this issue Nov 14, 2021
@arnavpisces @aucampia
Fixed the return type of parse function of ConjunctiveGraph (Issue RD…
20b3d1c 
…FLib#939)
@ghost ghost mentioned this issue Dec 14, 2021
Closed
@ghost ghost added the id-as-cntxt tracking related issues label Dec 24, 2021
@aucampia aucampia added good first issue Good for newcomers breaking change This involves or proposes breaking RDFLib's public API. labels May 22, 2023
mielvds added a commit to mielvds/rdflib that referenced this issue Aug 31, 2023
@mielvds
Add test case for RDFLib#939
dde12f0
@mielvds mielvds linked a pull request Aug 31, 2023 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This involves or proposes breaking RDFLib's public API. good first issue Good for newcomers id-as-cntxt tracking related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 939 return cg from parse mielvds/rdflib
2 participants
@aucampia @flacout