Show proper results from a replay #4127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging a replay into the window, or exiting to results screen from viewing replays in Gameplay, the replay loaded is not guaranteed to have values (e.g. perfect count, accuracy) in standard window. Since the replay itself doesn't contain information on judgement window, this gives the wrong information about accuracy and such at the beginning, unless clicking
CONVERT SCORE
later. This PR fixes this issue.Example replay (Test by dragging the file into the window, or later
WATCH REPLAY
and see the result):Map link
WilliamQiufeng - crafter2011 - fall damage - jindax's expert.zip
Before:
After:
Another issue fixed in this PR is the randomizer seed not being applied properly in replays with RND mod.
Check this replay with RND on for comparison:
1.zip