Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show proper results from a replay #4127

Merged
merged 2 commits into from
May 16, 2024

Conversation

WilliamQiufeng
Copy link
Contributor

@WilliamQiufeng WilliamQiufeng commented May 15, 2024

When dragging a replay into the window, or exiting to results screen from viewing replays in Gameplay, the replay loaded is not guaranteed to have values (e.g. perfect count, accuracy) in standard window. Since the replay itself doesn't contain information on judgement window, this gives the wrong information about accuracy and such at the beginning, unless clicking CONVERT SCORE later. This PR fixes this issue.

Example replay (Test by dragging the file into the window, or later WATCH REPLAY and see the result):

Map link

WilliamQiufeng - crafter2011 - fall damage - jindax's expert.zip

Before:
image

After:
image

Another issue fixed in this PR is the randomizer seed not being applied properly in replays with RND mod.
Check this replay with RND on for comparison:

1.zip

…ng results from a replay

(Removed an unindented space at Line Quaver#599)
@WilliamQiufeng WilliamQiufeng changed the title Convert to standard judgement on viewing results from a replay Show proper results from a replay May 16, 2024
@AiAe AiAe merged commit 228fac9 into Quaver:ui-redesign May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants