Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.0] Add a search filter for scroll velocity changes #4125

Draft
wants to merge 1 commit into
base: ui-redesign
Choose a base branch
from

Conversation

faluhub
Copy link
Contributor

@faluhub faluhub commented May 14, 2024

This pr adds a search filter for the amount of slider velocity changes in a map. Its short name is svc. Must refresh beatmaps before results show up :)

@AiAe
Copy link
Member

AiAe commented May 16, 2024

I think this needs to be improved to ignore scroll velocities at 1.00x, because they are marked falsely as scroll velocity.
For example this map will show when searching for svc>0 https://quavergame.com/mapset/map/16

@Emik03
Copy link
Member

Emik03 commented May 16, 2024

Wouldn't this also include osu! normalization SVs, so you can't just say "ignore 1x", it must be "ignore perceived 1x-ish". (rounded due to floating points)

@Illuminati-CRAZ
Copy link
Member

Clearly we should implement an SV difficulty calculator for this

@Illuminati-CRAZ
Copy link
Member

On a serious note, I personally don't think we should add scroll velocity count as a thing to filter by. A bunch of "normal" maps will be would be filtered out by "svc = 0" because they use SVs for BPM normalization, and at higher sv counts it stops being a good metric for distinguishing between SV maps.

Copy link
Member

@AiAe AiAe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read PR comments

@AiAe AiAe marked this pull request as draft May 24, 2024 18:21
@AiAe AiAe changed the title Add a search filter for scroll velocity changes [1.4.0] Add a search filter for scroll velocity changes May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants