-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLAPPO #299
Open
fandreuz
wants to merge
185
commits into
PyDMD:master
Choose a base branch
from
fandreuz:generic-linalg
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GLAPPO #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fandreuz
force-pushed
the
generic-linalg
branch
from
December 6, 2022 23:33
4b1e658
to
635e64a
Compare
TODO: replace |
fandreuz
force-pushed
the
generic-linalg
branch
9 times, most recently
from
December 30, 2022 11:04
e5e64e8
to
f2878f5
Compare
Reverted |
fandreuz
force-pushed
the
generic-linalg
branch
from
December 30, 2022 22:58
21244a6
to
9b8c622
Compare
TODO before closing the PR
|
fandreuz
force-pushed
the
generic-linalg
branch
from
August 2, 2023 22:53
194ec1c
to
7399ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR showcases a proof of concept for generic linear algebra in PyDMD (
cdmd.py
has been adapted to the new framework).At the moment the supported backends are PyTorch and NumPy, but I have some work-in-progress for SciPy's sparse matrices.
As part of this PR I'd like to discuss also the design, usability and extensibility of the
linalg
module.Fixes #298 and #297