Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return explained variance for truncated basis as well as slow modes when fitting mrDMD using a specified SVD rank #288

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

irisstone
Copy link

No description provided.

@irisstone
Copy link
Author

I've been editing a forked version of this repository for a project I'm working on. The edits I've made here have to do with being able to run mrDMD while specifying the svd rank while also returning the variance explained by that truncated basis, as well as the variance explained just by the slow modes at each level. I recently submitted a PR to my fork but thought it might also be useful to the broader community. No worries if not though; please obviously reject the PR if so!

@irisstone irisstone changed the title Edits for computing number of nodes above a selected explained variance for activity dashboard Return explained variance for truncated basis as well as slow modes when fitting mrDMD using a specified SVD rank Jul 27, 2022
@ndem0
Copy link
Member

ndem0 commented Sep 5, 2022

Dear @irisstone, thanks for sharing your new additions, surely they will be useful for someone in the community.
You have at the moment 15 tests that are failing. Could you please fix them?

@ndem0
Copy link
Member

ndem0 commented Nov 2, 2022

Dear @irisstone, any news about the failing tests?

@irisstone
Copy link
Author

Sorry, working on it! This was for a summer project that I am not currently actively engaged in, but I will get back to it at some point.

@ndem0
Copy link
Member

ndem0 commented Nov 10, 2022

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants