Fix portable if manifest is missing #2405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
bug
DioEgizio
requested changes
May 16, 2024
There was a problem hiding this comment.
That's not gonna fix that, look into the nsis code, we uninstall everything that was in the folder and reinstall again to not having residual DLLs that could cause issues. Honestly adding portable.txt to nsis installs shouldn't be a supported configuration, just use the portable .zip if you need that
|
This is more like a fix for portable in case they delete the manifest file.
Yeah I know that the situation described in the issue is not desired, but this doubles as both a fix for that situation but also for the mentioned one. |
Trial97
commented
May 16, 2024
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Trial97
commented
May 16, 2024
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Ryex
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2191
Basically, we should not touch the
portable.txtfile on the update