Add Hummingbird theme in composer.json #36198
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicosomb
commented
May 20, 2024
•
nicosomb
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Add Hummingbird theme in composer.json and adapt UI tests |
| Type? | improvement |
| Category? | CO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | UI tests 馃煝 |
| UI Tests | https://github.com/nicosomb/ga.tests.ui.pr/actions/runs/9352955630 |
| Sponsor company | PrestaShop SA |
nicosomb
force-pushed
the
add-hummingbird-composer
branch
2 times, most recently
from
6b8306d
to
8d0e501
Compare
jolelievre
reviewed
May 20, 2024
nicosomb
force-pushed
the
add-hummingbird-composer
branch
from
8d0e501
to
b7b173e
Compare
|
UI tests are failing, due to Hummingbird build steps. This PR is blocked, we have to improve the Hummingbird build (remove the |
nicosomb
force-pushed
the
add-hummingbird-composer
branch
from
f943e37
to
bdc548b
Compare
Progi1984
previously approved these changes
Jun 3, 2024
Progi1984
previously approved these changes
Jun 4, 2024
and adapt UI tests
nicosomb
force-pushed
the
add-hummingbird-composer
branch
from
cbbf7cf
to
0b262d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.