-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flag new traduction #36067
base: develop
Are you sure you want to change the base?
fix flag new traduction #36067
Conversation
medMethnani
commented
May 1, 2024
•
edited
edited
Questions | Answers |
---|---|
Branch? | develop / 8.1.x |
Description? | Fix the New flag on product image translation from back office. |
Type? | bug fix |
Category? | BO |
BC breaks? | no |
Deprecations? | no |
How to test? | The traduction will now show correctly on front page on the New products with badge New well translated if its French langue it show Nouveau,... |
UI Tests | [Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..](https://github.com/medMethnani/ga.tests.ui.pr/actions/runs/8915646840) |
Fixed issue or discussion? | NONE |
Related PRs | NONE |
Sponsor company | Med METHNANI. |
Hello @medMethnani! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been changed back and forth many times. Before changing anything, we need to analyze the situation.
Update, checked it out. Nothing to change here. French translators need to fix this translation.
Hello, this is my first contribution on Prestashop if you can help me what should i do next ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@medMethnani hello, and thank you for your contribution 👍
You should create an issue, with detailed steps to reproduce the bug, then the QA team will try to reproduce it, and from there we'll see what must be done.
Then you can link the issue in your PR's description, so that next reviewers can check it out
Hello @matthieu-rolland , thanks for your answer this is the bug link: #36076 |