Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to hide/show subflow on dashboard page #13280

Merged
merged 4 commits into from
May 24, 2024

Conversation

bsignoret
Copy link
Contributor

On the dashboard page, we want to be able to hide subflows.
In general, when a subflow fails, the flow also fails. This overloads the dashboard interface when there are many subflows.

I suggest adding a button to show or hide subflows.
A change has already been made in prefect-ui-library: PrefectHQ/prefect-ui-library#2375

Example

image

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

Copy link

netlify bot commented May 8, 2024

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9d344f8

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

@github-actions github-actions bot added the status:stale This may not be relevant anymore label May 23, 2024
@github-actions github-actions bot removed the status:stale This may not be relevant anymore label May 23, 2024
@bsignoret
Copy link
Contributor Author

Hello @pleek91 @znicholasbrown !

What do you think? Do you need more information?

Thank you

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @bsignoret, this slipped the radar; this LGTM

@znicholasbrown znicholasbrown merged commit 8c49ef3 into PrefectHQ:main May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants