-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nox sessions for running pre-commit and checking MANIFEST.in
#2695
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 104 104
Lines 9435 9435
Branches 2159 2159
=======================================
Hits 8987 8987
Misses 272 272
Partials 176 176 ☔ View full report in Codecov by Sentry. |
- name: Check MANIFEST.in | ||
os: ubuntu-latest | ||
python: '3.12' | ||
nox_session: manifest | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it so that MANIFEST.in
gets checked for every PR, but we can switch it to a weekly test after #2694 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only about 50% understand what is going on with this tox->nox transition, but insofar as this PR defines a few new sessions for checking the manifest and running pre-commit, I think I understand and it looks good :)
Awesome, thank you for the review! |
lint
session for Nox as a shortcut to runpre-commit run --all-files
. This is mostly syntactic sugar, but does remove the need to installpre-commit
manually.manifest
session for Nox to runcheck-manifest
, which checks that all appropriate files are included inMANIFEST.in
.check-manifest
inpyproject.toml
MANIFEST.in
accordingly