-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example notebook for MHD wave dispersion relations #2460
base: main
Are you sure you want to change the base?
Add example notebook for MHD wave dispersion relations #2460
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
+ Coverage 95.17% 96.93% +1.75%
==========================================
Files 104 104
Lines 9417 9165 -252
Branches 2154 0 -2154
==========================================
- Hits 8963 8884 -79
- Misses 276 281 +5
+ Partials 178 0 -178 ☔ View full report in Codecov by Sentry. |
Hi all. I have not forgotten about this PR. It should be ready for review within the next few days. Edit (25-05-2024): This may take a little longer than I expected, unfortunately. |
Description
As discussed in #2198, this PR adds an example notebook for the MHD dispersion module (
mhd_waves_
) that aims to introduce the three linear, ideal MHD waves while demonstrating the module's functionality.Motivation and context
Explained in detail in #2198. Should be complete before June.
Related issues
Closes #2198
To do