Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example notebook for MHD wave dispersion relations #2460

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TrestanSimon
Copy link
Contributor

Description

As discussed in #2198, this PR adds an example notebook for the MHD dispersion module (mhd_waves_) that aims to introduce the three linear, ideal MHD waves while demonstrating the module's functionality.

Motivation and context

Explained in detail in #2198. Should be complete before June.

Related issues

Closes #2198

To do

  • Introduce/explain Alfvén waves
  • Introduce/explain fast and slow magnetosonic waves
  • Graph phase and group velocities
  • Create and add diagrams

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/ labels Jan 12, 2024
Copy link

Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱

Our contributor guide has information on:

The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:

  • Try fixing CI / Python 3.11 test failures first.
  • Most pre-commit.ci - pr failures can be automagically fixed by commenting pre-commit.ci autofix below, followed by a git pull to bring the changes back to your computer.
  • If pre-commit.ci - pr says that a function is too long or complex, try breaking up that function into multiple short functions that each do one thing. See also these tips on writing clean scientific software.
  • If the CI / Documentation check ends with a cryptic error message, check out our documentation troubleshooting guide.
  • For a documentation preview, click on Details next to docs/readthedocs.org:plasmapy.

If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder.

Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples.

We thank you once again!

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (40e94e4) to head (a252af3).

❗ Current head a252af3 differs from pull request most recent head eeab346. Consider uploading reports for the commit eeab346 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   95.17%   96.93%   +1.75%     
==========================================
  Files         104      104              
  Lines        9417     9165     -252     
  Branches     2154        0    -2154     
==========================================
- Hits         8963     8884      -79     
- Misses        276      281       +5     
+ Partials      178        0     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy added this to the v2024.5.0 milestone Feb 6, 2024
@TrestanSimon
Copy link
Contributor Author

TrestanSimon commented May 21, 2024

Hi all. I have not forgotten about this PR. It should be ready for review within the next few days.

Edit (25-05-2024): This may take a little longer than I expected, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org notebooks Related to example Jupyter notebooks in docs/examples/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example notebook for MHD wave dispersion relations
2 participants