Increase speed of get_unique_bias for Characteristic objects #2236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I streamlined the
get_unique_bias
function on Characteristic objects inplasmapy.diagnostics.langmuir.py
. According to a (very basic) TimeIt, creating 200 Characteristic objects now takes 0.59 seconds instead of 12.02 seconds, a 20-fold improvement in speed. The primary change is restrictingget_unique_bias
to averaging only duplicated bias values, instead of taking averages for all data points, even redundant single-point averages on already-unique bias values.Motivation and context
The
get_unique_bias
function inplasmapy.diagnostics.langmuir.py
runs every time a new Characteristic object is created, which appears to include heavily-used operations like subtraction between existing Characteristics. Streamliningget_unique_bias
saves a lot of time when calculating plasma diagnostics on thousands of shots (according to my Python profiler,get_unique_bias
was responsible for 88% of my program's twelve-minute runtime, and it now completes in two minutes!)Note: my very basic TimeIt is found on a Google Colaboratory document here. If anyone catches an error in my code, I will fix it and be eternally grateful. I have not yet created a changelog entry in case any further edits are suggested.