pk-offline-update: Fix crash due to invalid g_auto declaration in switch / case #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch / case
'case PK_PROGRESS_TYPE_PERCENTAGE' is just a label and doesn't offer
any scope as such. So, 'tmp_perc' auto variable will be allocated in
the stack, but will not be initialized to 'NULL' for 'case:'
statements other than 'PK_PROGRESS_TYPE_PERCENTAGE', causing GLib to
consider the 'tmp_perc' garbage value as a valid memory address
allocated via 'g_malloc()', triggering an invalid 'free()' causing the
crash.
Rather than adding a scope '{}' within 'case', and causing a huge
noise in git diff, we just move the declaration to an upper scope.
sidt4
force-pushed
the
pk-offline-update-crash
branch
from
3bd6af5
to
aa5f2f8
Compare
hughsie
approved these changes
Mar 23, 2024
|
Thank you! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case PK_PROGRESS_TYPE_PERCENTAGEis just a label and doesn't offer any scope as such. So,tmp_percauto variable will be allocated in the stack, but will not be initialized toNULLforcase:statements other thanPK_PROGRESS_TYPE_PERCENTAGE, causing GLib to consider thetmp_percgarbage value as a valid memory address allocated viag_malloc(), triggering an invalidfree()causing the crash.Rather than adding a scope
{}withincase, and causing a huge noise in git diff, we just move the declaration to an upper scope.